feat(tcp): make TCP_NODELAY the default

Open shubhexists opened this issue 2 years ago • 3 comments

Description

Fixes: #4890.

Notes

Added no delay to be Some(true) by default whenever the new method is called.

[x] I have made corresponding changes to the documentation
[x] I have performed a self-review of my own code

Nov 23 '23 22:11 shubhexists

Hi, apologies for the mistake. Fixed the function comment and added to the PR to the Changelog.md file I read the issue wrong. I'll fix it as required Edit - Also checked the box in the 1st comment.

Nov 27 '23 14:11 shubhexists

Updated the Changelog and Cago.toml as asked @thomaseizinger

Nov 29 '23 10:11 shubhexists

Thanks! This is ready but we delay breaking changes for a while to batch them up. I marked it as draft so it doesn't get merged accidentally.

Can you deal with the CI error?

Nov 30 '23 07:11 thomaseizinger

sorry @shubhexists could not make the changes to your branch as you PR'd from master opened #5469 preserving your commits :) Thanks!

Jun 13 '24 12:06 jxs