rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

feat(dht)!: update republish interval and expiration time defaults

Open lidel opened this issue 3 years ago • 6 comments

Description

This patch applies changes from https://github.com/libp2p/specs/pull/451. In particular, the new defaults are:

  • Record Expiration: 48h
  • Record Republish Interval: 22h

Closes #3229.

Notes

Links to any relevant issues

  • https://github.com/libp2p/specs/pull/451
  • #3229

Open Questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

lidel avatar Dec 12 '22 18:12 lidel

@thomaseizinger I added ! to the title, given that this is a breaking change. Let me know in case I misunderstand the conventions of conventional commits.

mxinden avatar Dec 19 '22 09:12 mxinden

@thomaseizinger I added ! to the title, given that this is a breaking change. Let me know in case I misunderstand the conventions of conventional commits.

I guess this is semantically breaking yeah.

thomaseizinger avatar Dec 20 '22 03:12 thomaseizinger

@lidel friendly ping. Can you add a changelog entry? Let us know if you want us to take over.

mxinden avatar Jan 19 '23 17:01 mxinden

My first contribution here (:

Just added the changelog entry, let me know if anything else is required.

guillaumemichel avatar Jan 23 '24 19:01 guillaumemichel

This pull request has merge conflicts. Could you please resolve them @lidel? 🙏

mergify[bot] avatar Jan 23 '24 19:01 mergify[bot]

This pull request has merge conflicts. Could you please resolve them @lidel? 🙏

mergify[bot] avatar Feb 19 '24 06:02 mergify[bot]