protocols/identify: revise symbol naming

[jxs]

Description

Links to any relevant issues

https://github.com/libp2p/rust-libp2p/issues/2217 https://github.com/libp2p/rust-libp2p/pull/2215

Open Questions

Change checklist

• [x] I have performed a self-review of my own code
• [x] I have made corresponding changes to the documentation
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] A changelog entry has been made in the appropriate crates

[thomaseizinger]

cargo doesn't seem to be too happy about the version bumps. I can recommend running cargo check --all-targets --all-features --workspace locally to see if everything is alright :)

[jxs]

cargo doesn't seem to be too happy about the version bumps. I can recommend running cargo check --all-targets --all-features --workspace locally to see if everything is alright :)

right, Thanks. Addressed above reviews ptal again Thomas :)

[jxs]

This looks good to me. Thanks @jxs for the help.

Would you mind resolving the merge conflicts? Otherwise this is ready to merge from my side.

done, ptal again Max :)

[mxinden]

@jxs generally we prefer merge commits over force pushes as that makes incremental reviews easier. Easy to see what changed since ones last review.

Don't worry about keeping the commit history clean. Pull requests are always squashed into a single commit.

[mxinden]

Interoperability tests are failing again. I will merge here once we got those fixed. Sorry for the trouble.

You can follow along here: https://github.com/libp2p/test-plans/pull/42

[jxs]

Pulled from latest master, and fixed the remaining intradoc link problems. CI is finally green, ptal again :)

[thomaseizinger]

Let's get it in!