rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

Addition of protocol relevant information

Open AbhijithGanesh opened this issue 2 years ago • 2 comments

Signed-off-by: Abhijith Ganesh [email protected]

Description

Implementation of logs that will log the type of protocol used and other relevant information relevant to track usage.

Links to any relevant issues

Link to Issue

Open Questions

Change checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] A changelog entry has been made in the appropriate crates

AbhijithGanesh avatar Aug 11 '22 16:08 AbhijithGanesh

@thomaseizinger and @mxinden I would need help with this, can you review the PR and tell me what I am missing?

AbhijithGanesh avatar Aug 11 '22 16:08 AbhijithGanesh

I shall do the required

AbhijithGanesh avatar Aug 12 '22 01:08 AbhijithGanesh

Closing this in favor of https://github.com/libp2p/rust-libp2p/pull/2982.

thomaseizinger avatar Nov 02 '22 03:11 thomaseizinger

Thanks for your work anyway @AbhijithGanesh ! I closed this here because #2982 is closer to being merged and I want to avoid duplicate work :)

thomaseizinger avatar Nov 02 '22 03:11 thomaseizinger