rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

*: Consider using semverver

Open mxinden opened this issue 3 years ago • 4 comments

Description

Consider using https://github.com/rust-lang/rust-semverver to enforce semantic versioning. Instructions on how to integrate semverver in CI can be found on https://github.com/rust-lang/rust-semverver#ci-setup.

Motivation

Complying with Semver makes it easier for users to consume rust-libp2p. Having an automated compliance check makes maintaining rust-libp2p easier.

Are you planning to do it yourself in a pull request?

Help wanted!

mxinden avatar May 09 '22 12:05 mxinden

Hey @mxinden I am giving this a shot. Please see this PR

maschad avatar May 12 '22 20:05 maschad

Our current version bump results in a build failure see https://github.com/libp2p/rust-libp2p/pull/2647#issuecomment-1135208285

maschad avatar May 23 '22 22:05 maschad

Instead of semverver, we could consider using https://crates.io/crates/cargo-semver-checks.

mxinden avatar Sep 02 '22 02:09 mxinden

Thanks for reviving this @mxinden - I had lost track of it because of work, I agree, particularly because semverver is tightly coupled to specific nightly compiler versions and takes work to stay in sync. I will give it a try on the PR.

maschad avatar Sep 02 '22 16:09 maschad

With https://github.com/libp2p/rust-libp2p/pull/2647 I am closing here.

mxinden avatar Oct 12 '22 19:10 mxinden