rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

Rework `gossipsub-chat` example.

Open Jerrody opened this issue 3 years ago • 3 comments

And I made little refactoring of Cargo.toml.

TODO:

  • [ ] Change instruction for the tutorial.

Jerrody avatar Mar 19 '22 17:03 Jerrody

So, I made changes with Cargo.toml. If my PR will be accepted I need to change instructions for the usage in the example's code. And maybe make more comments on what things do.

Jerrody avatar Mar 22 '22 14:03 Jerrody

I don't quite understand the goal of this refactoring. What are you trying to showcase?

Sorry, I didn't see this message. The main reason is that for the current example we need to pass explicitly in args the address for connecting to the node. In my "refactored" example don't need to specify in the command line the address of the node, the connection is automatic.

Jerrody avatar Mar 26 '22 18:03 Jerrody

@mxinden So, I wait for your word mate. What should I change else?

Jerrody avatar Mar 28 '22 16:03 Jerrody

This is obsolete with #2996.

thomaseizinger avatar Nov 02 '22 03:11 thomaseizinger