js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

Markdown gets not correctly rendered in API.md

Open a1300 opened this issue 5 years ago • 4 comments

  • Version: v0.29.3
  • Platform:
  • Subsystem:

Type: Documentation Bug

Severity: Low

Description: A | symbol in a markdown table cell messes the markdown up

This markdown

image

Gets rendered as image

Affects

  • dialProtocol https://github.com/libp2p/js-libp2p/blob/master/doc/API.md#dialprotocol
  • peerStore.addressBook.get https://github.com/libp2p/js-libp2p/blob/master/doc/API.md#peerstoreaddressbookget
  • peerStore.addressBook.getMultiaddrsForPeer https://github.com/libp2p/js-libp2p/blob/master/doc/API.md#peerstoreaddressbookgetmultiaddrsforpeer

a1300 avatar Nov 26 '20 19:11 a1300

This is super weird. On vscode Markdown preview it shows up correctly. Did you understand the issue behind this?

vasco-santos avatar Nov 27 '20 09:11 vasco-santos

This is seems like a Github/Gist Markdown issue. I created an issue on the unofficial github bug repository https://github.com/isaacs/github/issues/1875

According to submitting-bug-reports-for-github-com I also will send a Bug report

a1300 avatar Nov 28 '20 13:11 a1300

Bug report on github.community https://github.community/t/bug-markdown-inline-code-blocks-with-pipe-symbols-within-a-table-cell-destroy-the-table/145896

a1300 avatar Nov 28 '20 13:11 a1300

Thanks for looking into this @a1300 ❤️

vasco-santos avatar Nov 29 '20 14:11 vasco-santos

API.md no longer has tables

wemeetagain avatar Sep 28 '23 03:09 wemeetagain