js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

[switch] Stats tests are not being run

Open jacobheun opened this issue 6 years ago • 2 comments

Since the stats test file is not a .spec.js file, they are not run automatically so it must be included by the browser / node test runner files. We should do an evaluation of the test suite to make sure everything is being run and in the proper environments.

jacobheun avatar Jul 09 '18 09:07 jacobheun

The current stats tests relay on the tcp transport which isn't going to work in the browser, so we should either rework the tests to run in both node and browser, or create a separate set of tests for browser environments. For now, I think we should enable them by requiring them in the test/node.js file.

dryajov avatar Jul 09 '18 18:07 dryajov

As mentioned in libp2p/js-libp2p-switch#271, we need browser tests added for stats. We should also do an inventory of the tests to ensure we have adequate tests in both node and the browser.

jacobheun avatar Jul 10 '18 00:07 jacobheun

Closing as no longer applicable

wemeetagain avatar Sep 28 '23 21:09 wemeetagain