js-libp2p icon indicating copy to clipboard operation
js-libp2p copied to clipboard

bug report: examples/pubsub/message-filtering/1.js

Open limingth opened this issue 2 years ago • 1 comments

I just tested this example and found a bug, here is the origin code

  //subscribe
  node1.pubsub.addEventListener(topic, (evt) => {
    // Will not receive own published messages by default
    console.log(`node1 received: ${uint8ArrayToString(evt.detail.data)}`)
  })
  node1.pubsub.subscribe(topic)

  node2.pubsub.addEventListener(topic, (evt) => {
    console.log(`node2 received: ${uint8ArrayToString(evt.detail.data)}`)
  })

  node3.pubsub.addEventListener(topic, (evt) => {
    console.log(`node3 received: ${uint8ArrayToString(evt.detail.data)}`)
  })

addEventListener(topic,

this first param should be fixed as "message", not topic.

==> addEventListener("message",

  //subscribe
  node1.pubsub.addEventListener("message", (evt) => {
    // Will not receive own published messages by default
    console.log(`node1 received: ${uint8ArrayToString(evt.detail.data)}`)
  })
  node1.pubsub.subscribe(topic)

  node2.pubsub.addEventListener("message", (evt) => {
    console.log(`node2 received: ${uint8ArrayToString(evt.detail.data)}`)
  })

  node3.pubsub.addEventListener("message", (evt) => {
    console.log(`node3 received: ${uint8ArrayToString(evt.detail.data)}`)
  })

limingth avatar Jul 04 '22 09:07 limingth

Good spot, thanks! Would you like to open a PR that updates the example?

achingbrain avatar Jul 13 '22 07:07 achingbrain