go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard

Connection multiaddress should match the address actually dialed (WSS, WebTransport, WebRTC)

Open aschmahmann opened this issue 1 year ago • 0 comments

It seems like a bug that wssConn.RemoteMultiaddr() doesn't contain the TLS or SNI components (and may also have an over-resolved domain name, but haven't tested that yet) and shows a much simpler multiaddr.

Context: I noticed the domain names of wss addresses were not showing up in the https://check.ipfs.network tool due to https://github.com/ipfs/ipfs-check/blob/b35461c0ac6dda2f32efceec52f2559f4c105bc4/daemon.go#L256

If this is buggy behavior it seems like this can be fixed in the websocket conn type, should a generic test for this be added to the transport suite?

aschmahmann avatar Sep 30 '24 20:09 aschmahmann