go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard
verified publisher icon libp2p

peerstore : add GetPeersForProtocol API

Open chaitanyaprem opened this issue 2 years ago • 2 comments

enhancement #1699

  • Added new API in peerstore for GetPeersForProtocol.
  • Implemented it for in memory peerstore.
  • Ran regression tests for in memory peerstore with -race flag to ensure no new races are introduced.
  • Add additional tests to validate new GetPeersForProtocol API

TODO:

  • Implement the new API for DS based peerstore
  • Run complete regression suite

chaitanyaprem avatar May 31 '23 10:05 chaitanyaprem

Hi @chaitanyaprem we discussed this in the go-libp2p open maintainers call. We're thinking of a large refactor of the PeerStore, so we're hesitant to change the current api right now. Would you like to join our open maintainers call? It would be great to have you participate since you're taking on issues related to the PeerStore and we would like to have you in the discussion. Here is the link to the community calendar which has the date & time for the maintainers call https://calendar.google.com/calendar/u/0/embed?src=libp2p.io_0q9682i3te7eanhe9q7ae1c58g@group.calendar.google.com

p-shahi avatar Jun 06 '23 18:06 p-shahi

ok @p-shahi . Will try to join this call from next week. I have curently stopped working on this as implementing this in peerstoreDS is not very clean. Wanted to wait for https://github.com/libp2p/go-libp2p/issues/2329 to get resolved.

chaitanyaprem avatar Jun 06 '23 23:06 chaitanyaprem

Happy Spring. I'm doing some spring cleaning and closing old PRs. There doesn't seem to be sufficient maintainer interest to keep moving this forward. Closing this for now, but if it comes up again we know where to find this PR.

MarcoPolo avatar Jun 03 '24 18:06 MarcoPolo