go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard

websocket: fix nil pointer in tlsClientConf

Open MarcoPolo opened this issue 3 years ago • 1 comments

It's possible (and common) to have a WebSocket transport without a tls client config. This leads to a nil pointer deref error when we set the ServerName.

This sets a default empty tlsClientConf and adds a test case.

Fixes https://github.com/libp2p/go-libp2p/issues/1769

MarcoPolo avatar Sep 21 '22 00:09 MarcoPolo

Suggested version: v0.23.1 Comparing to: v0.23.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.mod: the following requirements are needed
	github.com/libp2p/go-yamux/[email protected]
Run go mod tidy to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.23.1

gocompat says:

(empty)

github-actions[bot] avatar Sep 21 '22 00:09 github-actions[bot]

I removed the release commit. Let's first make sure we can build kubo before cutting a patch release.

marten-seemann avatar Sep 21 '22 18:09 marten-seemann