go-libp2p
go-libp2p copied to clipboard
libp2p
rewrite identify tests, remove mocknet package
The identify tests were the last consumer of the mocknet package (which in turn is the last consumer of go-libp2p-testing/net package). By rewriting those tests, we can get rid of mocknet, and we won't have to migrate go-libp2p-testing/net here.
there might be downstream dependents.
The only one in libp2p I can find is go-libp2p-kad-dht/ext_test.go. They'll have to find a way to deal with this. This code has caused us so much pain, it's time to get rid of it.
There's more in ipfs (bitswap and go-ipfs).
I agree this library is annoying, but it's all we have for large integration tests with many nodes.
If we just "remove" it here and tell upstream to "deal" with it, I guarantee they'll "deal" with it by not upgrading libp2p.
How about just not using it here? I'd also like to note that it's not all that useful for libp2p itself, because libp2p generally has no need for large-scale mock tests (it mostly needs to test things on the transport level). However, for the dht, bitswap, etc., the ability to mock is really useful.
I’d argue that it shouldn’t live within libp2p then (or at least not go-libp2p). How about moving it to a separate repo?
I’d argue that it shouldn’t live within libp2p then (or at least not go-libp2p). How about moving it to a separate repo?
That seems reasonable. Can we just move it to go-libp2p-testing?
We can. The original plan was to deprecate go-libp2p-testing, but we can just shift packages around: all the muxer and transport tests go here, and the mocknet tests go there.
mocknet is helpful for @celestiaorg.
We mock away OS networking in our protocols tests using it.
Moving it out seems inconsistent with the latest efforts to consolidate everything in one root go-libp2p repo. OOC, what problems was mocknet causing, and why is it annoying to the point where it needs to be invisible from people exploring the repo? Is there a plan to keep testing pkgs outside of the repo?
I've not reviewed this code yet, but at a high level my thoughts are:
- If this is a tool we are exposing to end users to be able to test large scale mock tests, then it makes sense that this should live in the go-libp2p repo and get tested/updated alongside everything else and for the same reasons we are consolidating everything else.
- If we want to deprecate this tool (mocknet), then I think we need a viable alternative for folks that is tested and lives in go-libp2p.
I'm not opposed to deprecating this and providing something similar/simpler that can support the original use case. But I think something like this is useful.
2022-09-09 conversation: we'll get the changes in to the tests so that go-libp2p doesn't use mocknet. It's a separate item/discussion on what to do with mocknet.
I rebased this PR and removed the commit that removes the mocknet package.