go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard

feat: catch panics in identify

Open Stebalien opened this issue 3 years ago • 1 comments

We haven't seen any panics in identify, but I'm going through and adding panic handlers to libp2p handlers because the benefits often outweigh the risk:

  • Risk: We might continue with corrupted state. In this case, that means continuing with a corrupted peerstore, which likely doesn't have a huge impact on anything. If something is really wrong, we'll crash somewhere else.
  • Benefit: if we panic when processing an identify response, we won't crash the entire node.

Part of #1389

Stebalien avatar Apr 09 '22 16:04 Stebalien

2022-09-16 conversation: we need to evaluate if this is the right place to do this or determine if our panic handlers in serialization functions are sufficient.

BigLep avatar Sep 16 '22 16:09 BigLep

Closing since we've done a major refactor of Identify.

marten-seemann avatar Feb 16 '23 07:02 marten-seemann