go-libp2p icon indicating copy to clipboard operation
go-libp2p copied to clipboard

Published 20 hours ago • verified publisher icon libp2p

Use of specific network interface for mDNS server

Open fouge opened this issue 5 years ago • 4 comments

I created this PR because I had to adapt the mDNS service to be used on specific interfaces. This can be useful for others as well.

The usage of a specific network interface is not mandatory, nil can be passed as well.

Let me know what you think or how can this PR can be improved :)

fouge avatar Oct 26 '20 10:10 fouge

This looks good to me. @aarshkshah1992 you've been looking at these things recently, any thoughts/concerns?

aschmahmann avatar Nov 13 '20 18:11 aschmahmann

Thanks guys for taking the time to review this PR. I am quite new to Go so even if the language is simple to learn, those comments are really appreciated to level up my dev skills in Go :smiley: I am going to consider @aschmahmann solution to use a more robust signature for NewMdnsService

fouge avatar Nov 16 '20 15:11 fouge

@aschmahmann @aarshkshah1992 I implemented the optional functions to set mDNS service parameters. Let me know what you think

fouge avatar Nov 16 '20 16:11 fouge

@aschmahmann aarshkshah1992 Anything I should do to merge this PR?

fouge avatar Nov 30 '20 16:11 fouge