go-libp2p-record icon indicating copy to clipboard operation
go-libp2p-record copied to clipboard

Remove gogo protobuf

Open guillaumemichel opened this issue 1 year ago • 1 comments

Gogo protobuf is deprecated. Move away from it.

Also updated dependencies.

guillaumemichel avatar Aug 07 '24 13:08 guillaumemichel

Yes, I am moving go-libp2p-kad-dht away from gogo, and there is a dependency on go-libp2p-record. The plan is to make a new release of go-libp2p-record so that consumers can move away from gogo when they are ready.

guillaumemichel avatar Aug 07 '24 14:08 guillaumemichel

@vyzo

you need to consider downstream consumers who are probably still using gogo with the generated code, which are likely to break.

Why would downstream consumers be impacted? They just use the generated file, no?

sukunrt avatar Jan 16 '25 14:01 sukunrt

there might be some api changes.

vyzo avatar Jan 16 '25 18:01 vyzo

The api changes are just that Marshal/Unmarshal are not methods on the generated structs, but instead functions that use reflect in the proto package. It's also missing the MarshalTo(SizedBuffer) method.

Should be a relatively straightforward change when upgrading.

MarcoPolo avatar Jan 16 '25 18:01 MarcoPolo