go-libp2p-pubsub-router icon indicating copy to clipboard operation
go-libp2p-pubsub-router copied to clipboard

Some tests timing out

Open guseggert opened this issue 3 years ago • 1 comments

This seems to be getting progressively worse over time...some tests are hanging and timing out waiting for propagation, see e.g. this run:

https://github.com/libp2p/go-libp2p-pubsub-router/runs/4035361341?check_suite_focus=true

guseggert avatar Nov 22 '21 21:11 guseggert

I think it might be because of https://github.com/libp2p/go-libp2p-pubsub-router/blob/1d5fc5c4ed11ec50a2ce08712f1fd6eb7e108130/pubsub.go#L91. I don't know what the setting does exactly but it seems the tests either succeed after around 1 minute or 11 minutes.

To make the checks pass I have increased the go test timeout to 20 minutes - https://github.com/libp2p/go-libp2p-pubsub-router/pull/91/commits/9977e77b7ea3da3eae3b909463e810dd54040359

My commit can be reverted once the tests are able to configure rebroadcastInterval (assuming my guess is correct of course).

galargh avatar Jan 14 '22 14:01 galargh