go-libp2p-daemon icon indicating copy to clipboard operation
go-libp2p-daemon copied to clipboard

Published 20 hours ago • verified publisher icon libp2p

Port prometheus to opencensus wrapper

Open bigs opened this issue 5 years ago • 3 comments

This change also introduces a very naive metricsModules map that collects, by name, all of the modules present in the daemon.

Sorry for the confusion here, @vyzo. @anacrolix and @lanzafame made a compelling argument to switch to OpenCensus and I decided to make the jump before it's too late. Still exposing a prometheus-friendly collection endpoint.

bigs avatar Mar 20 '19 22:03 bigs

Why not just expose all metrics, all the time? They're suitably name-spaced that choosing which ones to use can be done further down the line by tools better suited for it.

anacrolix avatar Mar 20 '19 23:03 anacrolix

maybe i misunderstood but doesn’t registering them cause them to impact performance? idea was to allow users to selectively not register metrics. definitely down to instrument everything if we don’t mind!

bigs avatar Mar 21 '19 01:03 bigs

Note CI is failing again.

vyzo avatar Mar 21 '19 07:03 vyzo