stork icon indicating copy to clipboard operation
stork copied to clipboard

fix: update the snapshotschedule post adding default reclaim policy

Open strivedi-px opened this issue 9 months ago • 0 comments

What type of PR is this?

failing test

What this PR does / why we need it In the startVolumeSnapshot function, we were fetching the latest copy of the snapshotschedule from the CR however in the handle() function which actually calls the startVolumeSnapshot() function, we were not persisting the updated default reclaimPolicy to Delete in the CR. Due to this, the ownerReference wasn't getting added to the volumeSnapshot resource. This PR adds the change to persist the changed default reclaimPolicy to the CR as soon as it's updated in the object.

Does this PR change a user-facing CRD or CLI?: No

Is a release note needed?: No

Does this change need to be cherry-picked to a release branch?: Yes, release-24.2.0 branch.

Test run Sample run from snapshot-k8s-new pipeline: https://jenkins.pwx.dev.purestorage.com/job/Users/job/strivedi/job/snapshot-k8s-new/9/console

Screenshot from 2024-05-25 21-11-22

strivedi-px avatar May 25 '24 13:05 strivedi-px