stork icon indicating copy to clipboard operation
stork copied to clipboard

PB-6976: Update backup cr status to failed status if backup failed to get started by portworx driver

Open shkumari-px opened this issue 9 months ago • 0 comments

Update backup cr status to failed status if backup failed to get started by portworx driver

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR: bug feature improvement cleanup api-change design documentation failing-test unit-test integration-test

What this PR does / why we need it: RCA Situation - Before running the post exec rule, we check if the snapshot id is populated for every volume Bug - If the snapshot id is not populated, we return nil at this point and we keep looping in the volume in Progress until the snapshot id is populated. In case where the backup fails in the inital stages only, before the backup starts (because of wrong credential or may be any other reason), we will keep looping in the in progress state only. Since we don't mark the backup cr status to failed because of the failed snapshot status

Updated screenshot Backup with pxs+non pxd vol azurechina bl, empty env type in stc Screenshot 2024-05-24 at 5 25 49 PM Screenshot 2024-05-24 at 5 35 00 PM

Backup with pxd+non pxd vol azureglobal bl, azurechina in cluster stc In case some non-pxd vol fails before the pxd vol, the error msg will be that of the last failure Screenshot 2024-05-24 at 6 03 59 PM

Check if post exec rule runs for cancelled backup locazcstcemptycancelbkp AzureChina backup location Screenshot 2024-05-24 at 3 29 25 PM Screenshot 2024-05-24 at 3 29 34 PM Screenshot 2024-05-24 at 3 30 31 PM

Azure china bl, cluster stc empty Screenshot 2024-05-24 at 2 46 06 PM successful post exec azurechinablstcempty

Azure public bl but AzureChina Cloud in stc Screenshot 2024-05-24 at 3 18 59 PM blazpublicstcazchina

Previous unit testing results Use Case AzureChinaCloud env type set in cluster stc but we are taking backup on azure global backup location Screenshot 2024-05-21 at 9 49 15 PM

'AzurePublicCloud' env type set in cluster stc but we are taking backup on azure china backup location Screenshot 2024-05-21 at 10 26 34 PM

No environment type set in cluster stc but we are taking backup on azure china backup location Screenshot 2024-05-21 at 10 41 21 PM

Does this PR change a user-facing CRD or CLI?:no

Is a release note needed?:no

Issue:
User Impact:
Resolution

Does this change need to be cherry-picked to a release branch?:no

ss of successful post exec rule execution Screenshot 2024-05-22 at 10 02 57 AM Screenshot 2024-05-22 at 10 04 04 AM

shkumari-px avatar May 21 '24 16:05 shkumari-px