stork
stork copied to clipboard
PB-6976: Update backup cr status to failed status if backup failed to get started by portworx driver
Update backup cr status to failed status if backup failed to get started by portworx driver
What type of PR is this?
Uncomment only one and also add the corresponding label in the PR: bug feature improvement cleanup api-change design documentation failing-test unit-test integration-test
What this PR does / why we need it:
RCA
Situation - Before running the post exec rule, we check if the snapshot id is populated for every volume
Bug - If the snapshot id is not populated, we return nil at this point and we keep looping in the volume in Progress
until the snapshot id is populated.
In case where the backup fails in the inital stages only, before the backup starts (because of wrong credential or may be any other reason), we will keep looping in the in progress state only. Since we don't mark the backup cr status to failed because of the failed snapshot status
Updated screenshot
Backup with pxs+non pxd vol azurechina bl, empty env type in stc
Backup with pxd+non pxd vol azureglobal bl, azurechina in cluster stc
In case some non-pxd vol fails before the pxd vol, the error msg will be that of the last failure
Check if post exec rule runs for cancelled backup
AzureChina backup location
Azure china bl, cluster stc empty
successful post exec
Azure public bl but AzureChina Cloud in stc
Previous unit testing results
Use Case
AzureChinaCloud
env type set in cluster stc but we are taking backup on azure global backup location
'AzurePublicCloud' env type set in cluster stc but we are taking backup on azure china backup location
No environment type set in cluster stc but we are taking backup on azure china backup location
Does this PR change a user-facing CRD or CLI?:no
Is a release note needed?:no
Issue:
User Impact:
Resolution
Does this change need to be cherry-picked to a release branch?:no
ss of successful post exec rule execution