stork icon indicating copy to clipboard operation
stork copied to clipboard

[PWX-37142] Removing error log in case update action fails

Open olavangad-px opened this issue 9 months ago • 1 comments

What type of PR is this?

bug improvement

What this PR does / why we need it: In case update Action fails for any reason an error message is logged and we eventually retry. As seen in migration volumes code path, this kind of logs may cause unnecessary confusion. So going ahead and removing the log.

Does this PR change a user-facing CRD or CLI?: No

Is a release note needed?: No

Does this change need to be cherry-picked to a release branch?: Yes, 24.2.0

Notes for reviewer: Please ignore the first commit during review. It's a simple moving of methods to utils file.

olavangad-px avatar May 06 '24 08:05 olavangad-px

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.18%. Comparing base (778a54c) to head (412b406). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   38.21%   38.18%   -0.03%     
==========================================
  Files          51       51              
  Lines       11387    11387              
==========================================
- Hits         4351     4348       -3     
- Misses       6648     6650       +2     
- Partials      388      389       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 10:05 codecov[bot]