openstorage icon indicating copy to clipboard operation
openstorage copied to clipboard

PWX-32899_pt4: K8s DNS fix

Open zoxpx opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

Autopilot and Stork (which vendor in this library) should not assume that Kubernetes DNS is configured with default .svc.cluster.local domain

FIX:

  • as a fix, we are modifying the hostnames to <service>.<endpoint> (and no .svc.cluster.local domain)
  • instead, we will rely on the /etc/resolv.conf to provide the correct search <dns-domain> entry, so DNS resolution will still work correctly

Which issue(s) this PR fixes (optional)
PWX-32899 (part 4)

See also:

  • part 1: https://github.com/libopenstorage/operator/pull/1437
  • part 2: https://github.com/libopenstorage/stork/pull/1629
  • part 3: https://github.com/pure-px/autopilot/pull/250

Testing Notes

Please check stork and autopilot PRs for manual tests results

Special notes for your reviewer:

TODO: This PR change will need to be vendored into stork and autopilot projects

zoxpx avatar Feb 09 '24 04:02 zoxpx

This PR is stale because it has been in review for 3 days with no activity.

github-actions[bot] avatar Feb 13 '24 01:02 github-actions[bot]

This PR is stale because it has been in review for 3 days with no activity.

github-actions[bot] avatar Apr 09 '24 01:04 github-actions[bot]

Thanks for the review Aditya -- merging the PR

zoxpx avatar Apr 16 '24 19:04 zoxpx