libnoon
libnoon
As far as I understood, TornadoScopeManager is for old tornado versions based on gen.coroutine. If you're using tornado 6, you should use ContextVarsScopeManager instead. See: https://github.com/opentracing/opentracing-python/pull/118 https://github.com/opentracing-contrib/python-tornado/pull/10
This PR fails on Python 3.5 and 3.6. Should we test the Python version and use the correct function call depending on it?
Here is my second try. Could you please review it? It seems one check failed, but I don't understand how my change could possibly cause this failure?
Hmm it looks like the link I suggest as replacement does not contain the same war as the intended one, because the tutorial https://glassfish.org/docs/latest/quick-start-guide.html#deploying-and-undeploying-the-sample-application-from-the-command-line seems to rely on an app...
It looks like a better fix for this problem has been merged. Closing this PR. Thanks!
To be fixed by #24802