mir-core icon indicating copy to clipboard operation
mir-core copied to clipboard

add `return` to ctor parameters

Open WebFreak001 opened this issue 2 years ago • 3 comments

only added this in algebraic.d (since that's the module I care about and found the bug in) works around dip1000 compiler bug in general should rather fix issues than introduce new ones

WebFreak001 avatar Nov 15 '23 11:11 WebFreak001

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (69b98a4) 38.68% compared to head (399008b) 38.68%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files          12       12           
  Lines         473      473           
=======================================
  Hits          183      183           
  Misses        290      290           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 15 '23 11:11 codecov-commenter

Looks good. However, I would like to get approval from an additional Symmetry developer. @kinke, doesn't it need to be tested on the private codebase first?

9il avatar Nov 15 '23 19:11 9il

@WebFreak001: You can test this in a SIL MR by changing the mir-core selection in master.selections.json to a git+https selection to your branch here.

kinke avatar Nov 17 '23 14:11 kinke