mir-algorithm icon indicating copy to clipboard operation
mir-algorithm copied to clipboard

Use dflags "-checkaction=context" "-allinst" in unittest configurations

Open nordlow opened this issue 3 years ago • 1 comments

nordlow avatar Jun 07 '22 13:06 nordlow

Hmm, quite a CI errors even though when

dub test --build=unittest-dip1008 --compiler=ldc2
dub test --build=unittest --compiler=ldc2
dub test --build=unittest --compiler=dmd

pass locally.

nordlow avatar Jun 07 '22 14:06 nordlow

Can somebody please review this so we can get this in?

nordlow avatar Aug 18 '22 09:08 nordlow

Ready again.

nordlow avatar Aug 18 '22 13:08 nordlow

Lots of seemingly unrelated failing CI jobs...

nordlow avatar Aug 18 '22 13:08 nordlow

That is an undesired change. If D allows to overload an assert behaviour with Mir, we can do so. But we definitely can't add allinst to the unittests because it allows to workaround linking bugs, while we want to catch them.

9il avatar Aug 19 '22 04:08 9il

That is an undesired change. If D allows to overload an assert behaviour with Mir, we can do so. But we definitely can't add allinst to the unittests because it allows to workaround linking bugs, while we want to catch them.

I understand.

What about adding a separate unit test configuration, say unittest-verbose or whatever other naming you prefer, for this then?

I thought

DFLAGS='-checkaction=context' dub test

would work but for some reason it excludes running the tests.

I really would like to be able to have better AssertError failure without having to edit the dub.sdl fail everytime.

nordlow avatar Aug 19 '22 06:08 nordlow

What about adding a separate unit test configuration, say unittest-verbose or whatever other naming you prefer, for this then?

Looks good

9il avatar Aug 19 '22 10:08 9il

What about adding a separate unit test configuration, say unittest-verbose or whatever other naming you prefer, for this then?

Looks good

Done at https://github.com/libmir/mir-algorithm/compare/8199f51fcbc023d2b9bdafe50703f3985037469f..f5f4a853e296d87b0963eddd70a70d7c5c00bdfb. Ready now. Github's diff algorithm could really need to TLC.

nordlow avatar Aug 19 '22 10:08 nordlow