Use dflags "-checkaction=context" "-allinst" in unittest configurations
Hmm, quite a CI errors even though when
dub test --build=unittest-dip1008 --compiler=ldc2
dub test --build=unittest --compiler=ldc2
dub test --build=unittest --compiler=dmd
pass locally.
Can somebody please review this so we can get this in?
Ready again.
Lots of seemingly unrelated failing CI jobs...
That is an undesired change. If D allows to overload an assert behaviour with Mir, we can do so. But we definitely can't add allinst to the unittests because it allows to workaround linking bugs, while we want to catch them.
That is an undesired change. If D allows to overload an assert behaviour with Mir, we can do so. But we definitely can't add allinst to the unittests because it allows to workaround linking bugs, while we want to catch them.
I understand.
What about adding a separate unit test configuration, say unittest-verbose or whatever other naming you prefer, for this then?
I thought
DFLAGS='-checkaction=context' dub test
would work but for some reason it excludes running the tests.
I really would like to be able to have better AssertError failure without having to edit the dub.sdl fail everytime.
What about adding a separate unit test configuration, say
unittest-verboseor whatever other naming you prefer, for this then?
Looks good
What about adding a separate unit test configuration, say
unittest-verboseor whatever other naming you prefer, for this then?Looks good
Done at https://github.com/libmir/mir-algorithm/compare/8199f51fcbc023d2b9bdafe50703f3985037469f..f5f4a853e296d87b0963eddd70a70d7c5c00bdfb. Ready now. Github's diff algorithm could really need to TLC.