liblouis icon indicating copy to clipboard operation
liblouis copied to clipboard

Refactor the German test files

Open bertfrees opened this issue 2 years ago • 4 comments

(Follow-up of #911 / #1100)

The de-g1-bidi-specs.yaml and de-g0-bidi-specs.yaml have some duplication with the de-g1.yaml and de-g0.yaml tests. On the other hand, there are tests in the bidi versions that are not in the regular versions, and visa versa. Same is true for the dictionary tests. It would be better to group all tests that are the same for both table variants, and all tests that differ. This will make it more clear how the two table variants differ. We might have to remove some capitals from the tests.

bertfrees avatar Mar 07 '22 11:03 bertfrees

Would be good if we had #1224 to do this properly

egli avatar Jun 01 '22 09:06 egli

de-g0-detailed-specs.yaml has a lot of duplication with de-g1.yaml (similarly for g1 and g2). The differences are that

  • the detailed table runs the tests in both directions
  • the detailed table expects different output in all tests where capitals or accents are involved

To merge the tables all tests would have to be run in both directions with the exception of capitals and accents

egli avatar Jun 02 '22 13:06 egli

Obviously bothDirection tests fail for capitals and accents in de-g1.yaml as capitalization and accents information is lost.

egli avatar Jun 02 '22 13:06 egli

The idea is to merge the two tests into a single file and keep similar tests close to each other. There will be different sections for stuff that is handled differently by the tables, i.e. caps with de-g1.yaml and caps with de-g0-detailed-specs.yaml

egli avatar Jun 02 '22 14:06 egli