Patrick Klein

Results 14 comments of Patrick Klein

This is my first PR to this project so weight my opinion accordingly. I do not see enough value in further offering (automatic) static IP configuration by the installer. In...

> How does #4783 relate to the IP address of the Pi-hole node? Sorry, i guess that was a typo on my side. I was referring to the original issue...

I would not change the default behaviour. First, I think that this is a case seldom observed in "the real world". Second, changing default behaviour is very intrusive for users...

Hi @dgtlmoon, thanks for the encouraging reply! > I see you are handling this by inserting a call on every Exception > > ``` > except content_fetcher.EmptyReply as e: >...

I've been working on refactoring the exception chain but believe that it would be better to address that in a separate PR. How do you feel about that? Can you...

Hey @dgtlmoon, so, how should we proceed with this?

Hello @dgtlmoon, do you have any plans to consider this PR for merging? I'd be happy to update the PR if you deem this feature important enough.

I am happy to do that, but we would need to agree on the scope of the PR. I suggest focusing on just the error notifications for now.

Hey, I've prepared a draft PR that implements basic functionality. I'd be happy like to hear your suggestions on what kind of behaviors like "notify only once after x-number of...

I've updated the PR: - Rebased onto master - should be mergable. - Added notify on failure field to edit form, failure notifications can now be enabled on a tag...