libigl-python-bindings icon indicating copy to clipboard operation
libigl-python-bindings copied to clipboard

Published 20 hours ago • verified publisher icon libigl

fit cubic bezier

Open alecjacobson opened this issue 3 years ago • 1 comments

Add the missing wrapper for igl::fit_cubic_bezier

The libigl function hard codes MatrixXd and doubles. So for now this needs to copy

AFAIK, Eigen's ND array support is still unstable, hence the libigl function outputs a std::vector<> of (same sized) matrices. In numpy, we'd probably rather have an nd array directly. For now, this wrapper matches the c++ output.

Meanwhile, numpyeigen's numpy_hacks_stable fork of pybind11 is spitting out some complaints to cerr. The output looks fine, but it'd be nicer to keep it quiet.

alecjacobson avatar Jun 28 '22 22:06 alecjacobson

Huh. This is hitting a really strange error. Somehow termios.h system header is being included from the mac36 CI and in there a bunch of macros are #defined including some that clash with a variable name in libigl B0. While we can force a change to libigl to avoid this specific B0 it seems silly. I'd rather figure out why this weird header ended up included. How can we debug this CI?

alecjacobson avatar Jul 26 '22 23:07 alecjacobson

Should review after https://github.com/libigl/libigl-python-bindings/pull/164/

py36 is too old and will no longer be supported, so if it works on >=3.7 then it should be safe to merge.

alecjacobson avatar Feb 04 '23 15:02 alecjacobson