libigl-python-bindings icon indicating copy to clipboard operation
libigl-python-bindings copied to clipboard

Do we still need numpyeigen?

Open alecjacobson opened this issue 3 years ago • 1 comments

Seems like pybind11 can directly interface to Eigen types. https://pybind11.readthedocs.io/en/stable/advanced/cast/eigen.html

So is numpyeigen no longer necessary?

alecjacobson avatar Oct 25 '21 19:10 alecjacobson

numpyeigen is doing codegen for the "matrix" of possible inputs, so that igl bindings work for {float,double} or {int32,int64} or {colmajor,rowmajor}

If there's a cleaner way to do this using pure pybind11 we should switch to it.

alecjacobson avatar Sep 06 '23 03:09 alecjacobson