pygit2 icon indicating copy to clipboard operation
pygit2 copied to clipboard

'certificate' parameter in RemoteCallbacks doesn't work

Open nu11ptr opened this issue 4 years ago • 0 comments

Looking at the code, I think the 'certificate' init param is supposed to be named 'certificate_check' so that if it is set, it overrides the class function (I believe this is how 'credentials' is working). As it stands, I don't see anywhere in the class where 'certficate' is referenced (fetch_opts it only references 'certificate_check') and some tests to self-signed servers didn't work until I created my own subclass with my own version of 'certificate_check'.

nu11ptr avatar Sep 26 '19 13:09 nu11ptr