pygit2 icon indicating copy to clipboard operation
pygit2 copied to clipboard

Mailmap with empty email address is not parsed

Open pulkomandy opened this issue 2 years ago • 1 comments

Environment:

  • Debian sid
  • Python 3.11.6
  • libgit2-1.7.1+ds-2
  • pygit2 1.13.3-1+b1

Test case:

from pygit2 import Mailmap
Mailmap.from_buffer("RealName <[email protected]> oldname <>")

Result:

ValueError: invalid argument: 'replace_email && *replace_email'

Expected result:

This syntax is accepted by Git (mapped names are shown in git log). Empty emails should be allowed.

pulkomandy avatar Jan 03 '24 17:01 pulkomandy

Is this correct set of email addresses by RFC? Shouldn’t they be separated by comma? And yes, putting the comma doesn’t help either.

mcepl avatar Sep 30 '24 16:09 mcepl