Don't initialize CoordinateSequence in constructor

[eyal0]

This ought to improve performance in the common case where initialization is unnecessary.

This fixes #764

[eyal0]

@dbaston Please take a look, thanks.

[pramsey]

@dbaston, is this a go or a no?

[dbaston]

It makes me nervous despite seeing the tests pass. I would rather creation sites clearly indicate that they do not require initialization by using the constructor that provides this parameter.

[eyal0]

Does such a constructor exist?

I'm trying to remember why I found this issue in the first place. I suppose some unit test of mine found it. Maybe performance tanked or something?

[dbaston]

Yes, see https://github.com/libgeos/geos/blob/4c3bd72ba73e9688b0712d9878d073559c84e4d6/include/geos/geom/CoordinateSequence.h#L85-L96

[robe2]

This has been sitting here for over a year are we thinking about doing anything about it @dbaston @eyal0 @pramsey

[pramsey]

Like @dbaston I hate mucking around in the initializers, because the knock-on effects are subtle. I defer to him as usual.

[robe2]

I'm just going to close this one out cause it's been sitting here for 2 years and is beginning to seriously annoy me. I think you are all agreed it's not a good idea.