geos icon indicating copy to clipboard operation
geos copied to clipboard

Use set_target_properties to set output attrs

Open Civitasv opened this issue 1 year ago • 3 comments

Use set_target_properties to set LIBRARY_OUTPUT_DIRECTORY, ARCHIVE_OUTPUT_DIRECTORY and RUNTIME_OUTPUT_DIRECTORY, in this way, geos will not interfere output settings of users' project.

Civitasv avatar Oct 18 '22 13:10 Civitasv

Is there a way to apply this to all of our targets without copy-paste? (benchmarks, tests, etc.)

dbaston avatar Oct 18 '22 13:10 dbaston

Is there a way to apply this to all of our targets without copy-paste?

For PDAL we have macros that roll up all of these kind of settings for the different categories of targets. See https://github.com/PDAL/PDAL/blob/master/cmake/macros.cmake for inspiration.

hobu avatar Oct 18 '22 13:10 hobu

Is there a way to apply this to all of our targets without copy-paste? (benchmarks, tests, etc.)

I think it can be achived by put all targets into a variable. Maybe there's a better way.

Civitasv avatar Oct 18 '22 13:10 Civitasv

I think it can be achived by put all targets into a variable. Maybe there's a better way.

I have done that. And I've added geos and geos_c.

Civitasv avatar Oct 28 '22 04:10 Civitasv

If you rebase to main do we get a green CI?

pramsey avatar Oct 31 '22 17:10 pramsey

If you rebase to main do we get a green CI?

I've done that.

Civitasv avatar Nov 01 '22 02:11 Civitasv

This PR addresses geos_c and geos but we have many more targets for benchmarks, tests, and utilities (geosop). I would prefer not to have all of these moved.

dbaston avatar Nov 01 '22 14:11 dbaston

We can add more targets into it.

Civitasv avatar Nov 01 '22 15:11 Civitasv