sshfs WIP: removal of trailing whitespace

Aug 17 '21 19:08 a1346054

Thank you! The problem with white-space fixes is that they make git blame much harder to use and there is nothing that prevents trailing whitespace from being introduced again in the future. So I would prefer if you could revert those.

Aug 23 '21 08:08 Nikratio

Would you take the whitespace fixes if we added a CI step to check for them? I've been hacking on an unrelated feature myself and my editor keeps complaining about them.

Aug 23 '21 20:08 ccope

Yeah, I guess so. But please still put them in a separate commit.

Aug 24 '21 07:08 Nikratio

I separated the pull request into individual commits, and additionally added an .editorconfig file so that trailing whitespace doesn't happen in the future.

Aug 24 '21 12:08 a1346054

I'll look into setting up a CI step today to enforce code style.

Aug 24 '21 17:08 ccope

I'd also hold off on merging this for the moment, we can bundle any/all formatting fixes together and then put the commit hashes in a .git-blame-ignore-revs file

Actually never mind, we can add the formatting commits to the ignore file whenever

Aug 24 '21 20:08 ccope

I don't think the .editorconfig file will be sufficient to ensure that this does not recur. There's too many editors that are not using it (including Emacs).

Can we split this into one pull request for whitespace + ignore file + CI changes, and a second one for the other changes?

Aug 25 '21 11:08 Nikratio

Split into #258

Aug 25 '21 11:08 a1346054

Rebased on latest master.

Leaving this PR open in case the .editorconfig file is considered useful.

Also still looking into how to add these particular fixes in an automated way.

Sep 16 '21 17:09 a1346054