Update readme and fix python tests
This is a major improvement to the readme, significantly improving build instructions. I also improve general usage instructions, and I port the readme to Github Flavored Markdown, which is more widely-used, widely-understood, and widely-supported. Lastly, I fix two python test warnings, See commit a1d58ae1be99571a88b8439b027abe6349b74658 and 03ee1f8aa0899268ec02b2f54849352df92a3a1d for detailed descriptions.
- fixes #99
- helps with #121
To see what the new readme looks like, look at my repo here: https://github.com/ElectricRCAircraftGuy/sshfs/tree/update_readme.
Why is Travis CI failing? It might be because it is set to use an old Python 3 version (3.5)? instead of something newer?
Looks like the pytest version that is being installed isn't compatible with Python 3.5. We'll have to either pin to an older pytest version, or test with a newer Python release.
Looks like the pytest version that is being installed isn't compatible with Python 3.5. We'll have to either pin to an older pytest version, or test with a newer Python release.
Python 3.5 is really old. Let's test with a newer Python release. How do we do that?
@Nikratio , which items are still blocking? I'll address any blocking issues to ensure you are okay merging it.
I can add your proposed contributor_info.md, or similar, file, for some of the details.
I'd like to have Travis CI use a later Python version. I'm not entirely sure how to do that. Some ideas include:
- Update this file to use
bionic(Ubuntu 18.04) instead ofxenial(Ubuntu 16.04). I think that'll bring in a newer Python version automatically. Or: - Update this file to manually install a later version of Python.
I prefer option 1 if that works as I think it will. Is there any reason not to update to 18.04, bionic?
So, what do I need to do to get this PR merged? Which items are blocking vs recommended but not blocking?
I think updating the CI to bionic is fine.
If you can move the alternative installation options to a separate file, I'd be happy to merge this.
Any update on this?
@Nikratio , I haven't had time to look at this again yet. Still on my todo list. If you'd like to make the fixes and merge, feel free to follow the github "command-line" instructions you should be able to see here by the merge button, then I believe you can check out my branch, make any changes yourself you see fit, and push to the master branch.
If you are unable to take it from here and make the fixes, I'll get back to it when able. Note that so long as you keep my commits intact and just add new commits on top of my commits to fix my commits, I will still show up as a contributor, so you making corrections to my PR here won't take that away.
Are you still interested in working on this? If not, I'll close the pull request in a few days.
@Nikratio , Would you be able to manually check out my branch, add the changes you'd like, and manually merge them to the main branch? If so, you get the fixes you want and I get credit for the parts of the PR you kept.
I swear to Christ! Nobody gives a dick about this stupid shit. WTF am I still getting Dick sucking email for!. You all suck. You suck at life, can't hack anything and You're Mom's annoyed with your "robot project" homo.
On Mon, Apr 15, 2024, 2:24 AM kalvdans @.***> wrote:
@.**** commented on this pull request.
In README.md https://github.com/libfuse/sshfs/pull/238#discussion_r1565367780:
+[
py.test][py.test] Python module. It also requires configuring ssh keys for passwordless login to +yourself via localhost. See the detailed notes about ssh key generation and setup +below.
+
bash +ninja +python3 -m pytest test/ # (Optional, but recommended) run the tests +sudo ninja install ++ +### 2. Detailed instructions + +Tested 22 Dec. 2020 on Ubuntu 20.04. + +1. Download andcdinto the source code
- To download the latest source code:
👍, moving how to build from git to CONTRIBUTING.md would be good.
— Reply to this email directly, view it on GitHub https://github.com/libfuse/sshfs/pull/238#discussion_r1565367780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNTXKKBRL4ZZOLZ7R6YJ63Y5OFEXAVCNFSM4VGVD4XKU5DIOJSWCZC7NNSXTPCQOVWGYUTFOF2WK43UKJSXM2LFO45TEMBQGAZTENBTGMZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>