Static library - zlib.dll is created instead of zlib.lib

[dmitri-fm]

Description

Zlib is built as static library, but the library has .dll extension

Example/How to Reproduce

Configure/Generate with CMake as static library, open solution in Visual Studio

Possible Fix

No response

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

• OS: Windows 10
• Version: https://github.com/libcpr/cpr/releases/tag/1.10.5

[COM8]

@vergol thanks for reporting. I will try to look into it as soon as possible.

[COM8]

I can not reproduce this. When I do cmake .. -DBUILD_SHARED_LIBS=OFF and then open the VS solution I get:

Could it be, that you first build cpr as shared (including zlib) and then you switched to static without deleting the build directory before that?

In theory this should be handled by the following code: https://github.com/libcpr/cpr/blob/master/cmake/zlib_external.cmake#L18

[COM8]

Closing for no response