JavascriptSubtitlesOctopus icon indicating copy to clipboard operation
JavascriptSubtitlesOctopus copied to clipboard

JSO doesn’t nor enables users to set storage size

Open TheOneric opened this issue 3 years ago • 1 comments

ASS rendering depends on the original video’s storage resolution. Even if we can somehow obtain the video resolution of the current associated video stream, this may not be correct if there are multiple resolutions available to choose from or resolution is dynamically adjusted for bandwidth. Thus JSO should at least (also?) provide a means for users of the regular JS interface to manually set storage size from e.g. some out-of-band metadata.

Currently all subtitles (without LayoutRes{X,Y}) for which libass’ fallback guess is wrong and use affected features thus render incorrectly.

TheOneric avatar Nov 15 '22 20:11 TheOneric

https://github.com/ThaUnknown/jassub/blob/main/src/jassub.js#L286 videos have a resize event which fires whenever the video resolution changes, be that because the video track was changed or because of some encoding black magic

ThaUnknown avatar Nov 20 '22 21:11 ThaUnknown