Allegro on homebrew is missing mp3 support

[fatcerberus]

Just noticed I can't load .mp3 files in neoSphere on macOS, so I checked the homebrew package for Allegro 5 it seems there's no dependency on minimp3, which suggests the homebrew binaries are being compiled without MP3 support: https://formulae.brew.sh/formula/allegro

[SiegeLord]

Does homebrew have minimp3?

[fatcerberus]

Hmm, maybe not. brew install minimp3 didn't find anything.

[SiegeLord]

It's certainly possible to add minimp3 to homebrew in principle, but they might not be happy with it as per https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff. Another option might be for Allegro to vendor it, but I'd rather not do that as it might create problems for Linux distro packaging.

[SiegeLord]

Maybe the vendoring option isn't that bad, actually. The license of minimp3 is public domain and if Debian objects, they can simply remove it from Allegro as part of their patching process.

So, the way forward here is:

• Add a deps/include directory in Allegro's source.
• Check in the 2 minimp3 headers into it.

The build system is already set up to look into that directory, so it should just work from there on.

[SiegeLord]

Well, let me ask the Homebrew folks directly first actually... this naturally they also discourage vendoring: https://github.com/Homebrew/discussions/discussions/2806