allegro5 icon indicating copy to clipboard operation
allegro5 copied to clipboard

Published 20 hours ago • verified publisher icon liballeg

Please check this package I uploaded to pypi

Open Mino260806 opened this issue 3 years ago • 3 comments

I have uploaded the allegro5 wrapper to pypi for users who can't build it themselves. Please let me know if there's something I should change.

https://pypi.org/project/allegro5/

Mino260806 avatar May 02 '21 17:05 Mino260806

Hi, this is great; thank you for setting that up! We've wanted to set up a pypi package for awhile, but never got around to it.

Here are some changes we'd probably make if we were to do it:

  • License would be changed to ZLib to match this repository's license; it's just simpler all around to have (thin) wrappers have the same license as the original
  • We'd probably not package the dll's with the package, and instead require the users to install the binaries alongside their Python scripts. It's certainly could be argued that this is less convenient, but I think it's better overall for platforms like Linux and OSX (which we would want to support in Python) where we don't provide binaries ourselves (instead relying on package managers). Maybe it could be argued that on Windows, since we do provide binaries there, we should include them alongside the package as well.

Do you have a repository which contains the package scripts? Would you be interested in contributing it to our Python folder (although that'd probably also require adding some of Allegro devs to maintainers of the pypi package, so that's up to you).

SiegeLord avatar May 02 '21 19:05 SiegeLord

Hello, thanks for replying so quickly. I noted all your points and I'd implement the changes tomorrow as soon as I get home. I don't have a repository yet (most probably because I didn't commit a huge change on the prebuilt allegro.py) I just added some functions definitions that were originally made by macros in *.h files and weren't included by cmake, plus added some files to make it an importable python module. But if it's necessary I will make a repository tomorrow. ( in about 14 hours from now)

Mino260806 avatar May 02 '21 23:05 Mino260806

I have just updated the package. Please check the changes: https://pypi.org/project/allegro5/ And I alse made a repo https://github.com/Mino260806/allegro5-python It would be a great pleasure to me to add my repo to allegro5 main repo. So just tell me what I need to do and which devs should I add to maintainers of pypi package. @SiegeLord

Mino260806 avatar May 03 '21 18:05 Mino260806