libMesh
Fix for overwriting nodesets
- When creating sidesets from nodesets if the sideset shares an id with a nodeset they are combined
- This checks first that the two are actually the same (same id and same nodes)
- If they are not the same the instead of overwriting a new id is assigned to the new nodeset
- If this is to be merged some tests in MOOSE would have to be re-golded
refs idaholab/moose#30085
Should be merged after idaholab/moose#30291
Job Coverage, step Generate coverage on ca63b3e wanted to post the following:
Coverage
| 5063fb | #4121 ca63b3 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 63.41% | 63.41% | +0.00% | 97.44% | |
| Hits | 74790 | 74814 | +24 | 38 | |
| Misses | 43153 | 43162 | +9 | 1 | |
This comment will be updated on new commits.
I checked the tests that failed and it looks like it was because it was tested on those three MOOSE tests I fixed in idaholab/moose#30291 before the PR made it to next. I invalidated them to run them again. Hopefully that should fix it.
meshmodifiers/element_subdomain_modifier.boundary/moving_boundary FAILED (TIMEOUT) [FINISHED]
A timeout, so probably random, but I'm going to kick it again to be safe.
And of course the MOOSE ARM mac failure is no more than the same civet breakage; we'll ignore that.
That's what I figured. Those two tests weren't failing when I first opened the PR and they aren't failing when I run them locally.