libMesh
Added error when stitching fails
When no matching nodes are found, libmesh throws an error now
refs idaholab/moose#27758
I like the idea, but it looks like we're interfering here with higher-level error handling in MOOSE CI.
We could probably add a try/catch there to be able to add compatibility with this with a smooth transition?
Job Coverage, step Generate coverage on c4f02bf wanted to post the following:
Coverage
| 5b27fa | #4072 c4f02b | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 62.51% | 62.51% | +0.00% | 100.00% | |
| Hits | 72994 | 72996 | +2 | 2 | |
| Misses | 43779 | 43778 | -1 | 0 | |
This comment will be updated on new commits.
I would definitely need to test this before we could merge. I think there may be some situations where we rely on the current behavior of not throwing an error when nothing is stitched.
I'll go ahead and try adding a try/catch. Also I know users often ignore warnings but if there are cases where it relies on it not throwing an error then maybe making it a warning instead might work?
I could be talked into a warning. Not literally libmesh_warning(), but something informative to libMesh::out.
Sorry this took so long, but I changed it to a warning statement (using libmesh::out). I was going to do a try/catch but I think that might still interfere with MOOSE's error handling?