libmesh icon indicating copy to clipboard operation
libmesh copied to clipboard

Normal normals

Open roystgnr opened this issue 1 year ago • 1 comments

A user suggested that they might have seen normal vectors inverted on a flipped Tri element. I couldn't reproduce that, but I did see normal vectors inverted on a flipped Edge element. This PR fixes that, and adds more unit tests to make sure such a gross error shouldn't recur. More subtle potential errors are going to need more subtle tests at some point.

roystgnr avatar Oct 15 '24 21:10 roystgnr

Job Coverage, step Generate coverage on b0cd68f wanted to post the following:

Coverage

db32ea #3971 b0cd68
Total Total +/- New
Rate 62.33% 62.33% +0.00% 100.00%
Hits 72643 72646 +3 6
Misses 43901 43902 +1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

moosebuild avatar Oct 16 '24 00:10 moosebuild

Rebased on master to see if the MOOSE fixes have made it in yet.

roystgnr avatar Oct 22 '24 21:10 roystgnr

And again

roystgnr avatar Nov 27 '24 16:11 roystgnr

This looks lie a pretty self-contained bug fix, so probably a candidate for the 1.8.x branch @roystgnr?

jwpeterson avatar Dec 02 '24 16:12 jwpeterson

Yeah, I'd say so. Our only problem with it was the downstream app code that had been relying on the broken behavior.

roystgnr avatar Dec 02 '24 23:12 roystgnr