libmesh icon indicating copy to clipboard operation
libmesh copied to clipboard

First stab at importing tracing routines

Open loganharbour opened this issue 3 years ago • 7 comments

loganharbour avatar Nov 08 '22 20:11 loganharbour

Job Coverage on ae116d8 wanted to post the following:

Coverage

09d0e4 #3432 ae116d
Total Total +/- New
Rate 59.74% 59.89% +0.15% 92.39%
Hits 48341 48662 +321 328
Misses 32578 32594 +16 27

Diff coverage report

Full coverage report

This comment will be updated on new commits.

moosebuild avatar Nov 08 '22 22:11 moosebuild

@roystgnr everything here is complete and fully tested - this is definitely only a chunk of it, but could be reviewed now.

loganharbour avatar Nov 10 '22 17:11 loganharbour

I'll also add that I think I have the most of the non-tool changes made, that is the stuff to Elem and the derived classes. That was my goal here - get those in first, and then add a few tools.

loganharbour avatar Nov 10 '22 17:11 loganharbour

@roystgnr - good to go.

loganharbour avatar Nov 14 '22 20:11 loganharbour

Re the tolerance stuff: the last few tests run these scaled with element features on the order of [1e-8,1e8]

loganharbour avatar Nov 15 '22 14:11 loganharbour

This is exciting! We'll be able to add volumetric mesh geometries to OpenMC after this is merged (at the moment only surface mesh geometries are allowed). OpenMC already optionally links to libmesh for volume mesh tallies, but this will make multiphysics coupling substantially more straightforward. :smile:

gridley avatar Jan 30 '23 14:01 gridley

Oh hi @gridley. Yeah, this is completely OpenMC driven after some conversations with @pshriwise. I've got another branch pulling over the rest of the routines, just haven't made a PR yet. On that note - thanks for the reminder to finish this up 😆

loganharbour avatar Jan 30 '23 15:01 loganharbour