libKriging icon indicating copy to clipboard operation
libKriging copied to clipboard

Remove space after operator""

Open MichaelChirico opened this issue 9 months ago • 3 comments

For no particular reason I saw Dirk's PR to another repo in my GitHub home page:

https://github.com/marzer/tomlplusplus/pull/263

I searched CRAN for other similarly-affected packages, which includes this one, and am sending along the fix.

MichaelChirico avatar Mar 12 '25 05:03 MichaelChirico

@MichaelChirico For completeness this first affected Date via package RcppDate and has been merged upstream too; I also fixed RcppSimdJSON which had already been addressed upstream.

eddelbuettel avatar Mar 12 '25 12:03 eddelbuettel

Thanks! My first thought was it's a new CRAN check but I guess CRAN doesn't check all bundled sources. My original plan was to send fixed to all the affected packages:

https://github.com/search?q=org%3Acran%20%2Foperator%22%22%20%2F&type=code

But then I saw your {BH} there and started to think maybe I don't know what I'm doing if you haven't made a sweep of your packages yet :)

Is this something that only comes up with rare/overpunctilious compilers? Or you're taking a minimal "if CRAN doesn't flag it I won't bother" approach?

MichaelChirico avatar Mar 12 '25 14:03 MichaelChirico

My decision rule is much simpler: if it affects a package of mine, I correct it (both in the package and by reaching out to upstream which lead to two PRs for the three affected packages).

Also note that there are two incantations: operator"" and operator "" . The latter one is more common. The whitespace preceding "" is fine, it is the one after that tickles the 'literal whitespace' noise.

eddelbuettel avatar Mar 12 '25 14:03 eddelbuettel