nestjs-redis icon indicating copy to clipboard operation
nestjs-redis copied to clipboard

Published 20 hours ago • verified publisher icon liaoliaots

refactor: update nestjs dependencies

Open mahsumurebe opened this issue 1 year ago • 10 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #516

What is the new behavior?

Does this PR introduce a breaking change?

    • [ ] Yes
    • [x] No

Other information

mahsumurebe avatar Jun 16 '23 22:06 mahsumurebe

Any estimate for merging this? My team is excited for SWC support in v10 Nest.js for which this bump is needed 🙏

pneme avatar Jun 20 '23 10:06 pneme

Hey @liaoliaots ! Any updates?

v-petukhov avatar Jun 22 '23 08:06 v-petukhov

@mahsumurebe, I think this PR should also update the requiremenets in the readme for Nest and Node

andresemartinez avatar Jun 22 '23 14:06 andresemartinez

any news? it has been some time since last commit is this maintained? @liaoliaots

satanshiro avatar Jul 02 '23 08:07 satanshiro

Hi @liaoliaots

Necessary improvements have been made. Can you check the pull request?

mahsumurebe avatar Jul 03 '23 12:07 mahsumurebe

@liaoliaots Would much appreciate your support on this. We're kind of blocked on upgrading to Nest.js v10 because of the nestjs-redis not supporting it. Anything I can do from my side, I will be glad to support. I thank you for your efforts on this project.

heiba avatar Jul 06 '23 08:07 heiba

Hi @liaoliaots

Can you check the pull request?

jorcelinojunior avatar Jul 13 '23 22:07 jorcelinojunior

it's been close to 2 months now, is it time to create a fork instead?

satanshiro avatar Jul 31 '23 11:07 satanshiro

it's been close to 2 months now, is it time to create a fork instead?

It's already created by @Songkeys

https://github.com/liaoliaots/nestjs-redis/issues/516#issuecomment-1626898431

v-petukhov avatar Jul 31 '23 11:07 v-petukhov

It is possible to override dependencies in package.json but do so at your own risk. The following worked via npm:

"overrides": {
    "@liaoliaots/nestjs-redis": {
      "@nestjs/common": "$@nestjs/common",
      "@nestjs/core": "$@nestjs/core"
    }
},

dougal83 avatar Jan 13 '24 21:01 dougal83