liangwen12year
liangwen12year
> The bond tests are still failing - are we still waiting for the networkmanager fix to get into a compose? Was the arp fix supposed to help some of...
[citest]
Please consider signing off the commit to remove the DCO failure, https://github.com/linux-system-roles/network/blob/main/contributing.md#sign-off-your-commit
The unit test, integration test and example need to be added. But overall, the implementation of this feature support is quite nice.
``` [wenliang@localhost network]$ tox -e yamllint ./tests/tests_cloned_mac_initscripts.yml 5:81 error line too long (82 > 80 characters) (line-length) ``` You may consider to ignore the line-length check of `tests_cloned_mac_initscripts.yml` in .yamllint.yml...
[citest]
[citest]
A nit, maybe you can also provide an example under the `./examples/` directory.
yamllint check failed: ``` ./tests/playbooks/tests_cloned_mac.yml Error: 62:81 [line-length] line too long (84 > 80 characters) Error: 72:81 [line-length] line too long (83 > 80 characters) ERROR: yamllint: commands failed ```
[citest]