AndroidFlowLayout A mistake in onMeasure function.

A mistake in onMeasure function.

Open xyc112233 opened this issue 9 years ago • 6 comments

There is a mistake in your code:

        if (childLeft + childWidth + paddingRight > myWidth) {
            childLeft = paddingLeft;
            childTop += mVerticalSpacing + lineHeight;
            lineHeight = childHeight;

Please change it to:

        if (childLeft + childWidth + paddingRight > myWidth) {
            childLeft = paddingLeft + childWidth;
            childTop += mVerticalSpacing + lineHeight;
            lineHeight = childHeight;

Aug 20 '15 07:08 xyc112233

Sorry, have you ever run the code to see what happens if you changed the code like that ?

Aug 20 '15 09:08 liangfeidotme

I agree with xyc112233 There is a mistake in the following code:

if (childLeft + childWidth + paddingRight > myWidth) {
                childLeft = paddingLeft;
                childTop += mVerticalSpacing + lineHeight;
                lineHeight = childHeight;
} else {
                childLeft += childWidth + mHorizontalSpacing;
}

change to : (This works well for me)

if (childLeft + childWidth + paddingRight > myWidth) {
            childLeft = paddingLeft;
            childTop += mVerticalSpacing + lineHeight;
            lineHeight = childHeight;
}
childLeft += childWidth + mHorizontalSpacing;