xcstrings-tool icon indicating copy to clipboard operation
xcstrings-tool copied to clipboard

Support caching generated outputs to workaround incremental build bugs

Open liamnichols opened this issue 9 months ago • 1 comments

liamnichols avatar Apr 03 '25 21:04 liamnichols

✅ Pull Request passed benchmark checks

Summary

Thu Apr 3 21:10:59 UTC 2025

===========================================================================================================
Threshold deviations for XCStringsToolBenchmarks:StringGenerator.generateSource(for:tableName:accessLevel:)
===========================================================================================================
Time (total CPU) (ms, Δ) main pull_request Difference Δ Threshold Δ
p0 327 311 -16 0
p25 327 311 -17 0
p50 359 319 -40 0
p75 371 323 -48 0
p90 371 345 -26 0
p99 371 345 -26 0
p100 371 345 -26 0

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.


Comparing results between 'main' and 'pull_request'

Host 'Mac-1743713509277.local' with 3 'arm64' processors with 7 GB memory, running:
Darwin Kernel Version 23.6.0: Thu Dec 19 20:45:54 PST 2024; root:xnu-10063.141.1.703.2~1/RELEASE_ARM64_VMAPPLE

XCStringsToolBenchmarks

StringGenerator.generateSource(for:tableName:accessLevel:) metrics

Time (total CPU): results within specified thresholds, fold down for details.

Time (total CPU) (ms) * p0 p25 p50 p75 p90 p99 p100 Samples
main 327 327 359 371 371 371 371 3
pull_request 311 311 319 323 345 345 345 4
Δ -16 -16 -40 -48 -26 -26 -26 1
Improvement % 5 5 11 13 7 7 7 1

github-actions[bot] avatar Apr 03 '25 21:04 github-actions[bot]

This has definitely made an improvement to our builds and no negative side effects so far! Be awesome to get this into stable, if you end up doing https://github.com/liamnichols/xcstrings-tool/issues/133 before this is in having this branch rebased would be awesome too.

Brett-Best avatar May 23 '25 14:05 Brett-Best