darktile icon indicating copy to clipboard operation
darktile copied to clipboard

Crashes on vttest

Open ghost opened this issue 7 years ago • 12 comments

Crashes on vttest 1 (cursor movements). Most other tests need work too.

There is some discussion on alacritty's vttest issue thread that may be useful. https://github.com/jwilm/alacritty/issues/240

ghost avatar Nov 28 '18 22:11 ghost

This is really useful, thank you. I wasn't aware of vttest until now. I'll give it a run tomorrow.

liamg avatar Nov 28 '18 22:11 liamg

No problem, I am always happy to see new terminals come up. Yours is quite popular, hope it fares well. FYI vttest is a bit of a bear to get through, but once done you will know the vt100/vt102 manuals inside and out. :)

ghost avatar Nov 28 '18 23:11 ghost

Yep, I know this is going to be painful, but hopefully worth it. I'll probably split this into issues for each test, and possibly reimplement vttest internally so I can automatically test it passes on builds.

liamg avatar Nov 30 '18 08:11 liamg

Wow, even iTerm fails these.

liamg avatar Nov 30 '18 08:11 liamg

Oh, and I've just realised you have to switch to 80x24 before you attempt these, for anyone trying it.

Easiest way to do that is ctrl + shift + d/cmd + d and resize.

liamg avatar Nov 30 '18 08:11 liamg

I crashed the first time too. :) (I crashed again long after passing vttest when I logged into a VMS system and ran the LSE editor. Man those DEC guys were brutal...)

ghost avatar Nov 30 '18 22:11 ghost

Well, I'm no longer crashing on my test branch, but there's a long way to go.

One thing I've noticed is lots of \x1b[1g and \x1b[2g which I cannot find documented anywhere. The docs mention 0g meaning clear tab (I think this means move back to the last tab stop?) and 3g which means clear all tabs, but not those other two. Have you found a good resource that goes into detail on these codes? Most places just say "Tab Clear" which doesn't explain the expected behaviour at all.

liamg avatar Dec 04 '18 14:12 liamg

In fact the VT100 manual says "Any other parameter values are ignored." so I guess vttest is making sure I ignore them.

liamg avatar Dec 04 '18 14:12 liamg

Hmm, yes that is what my emulator does: unknown parameters are silently ignored. Also, if you haven't already seen xterm's control sequences page: https://invisible-island.net/xterm/ctlseqs/ctlseqs.html . I find it handy in that it shows VT220/320/420 sequences in one place, a little easier than searching through those manuals separately.

ghost avatar Dec 05 '18 00:12 ghost

Yeah, it's apparently my most visited webpage too, haha!

liamg avatar Dec 05 '18 13:12 liamg

Crash fixed in #119

New issues for tests 1 and 2 at #120 and #121

liamg avatar Jan 04 '19 13:01 liamg

The zombie rises again. :) 0.0.10 darktile release crashes on the VT102 tests (test 8).

ghost avatar Jan 10 '22 23:01 ghost