Liam DeBeasi

Results 615 comments of Liam DeBeasi

Thanks for the issue. Do you have examples of apps that implement this behavior? Toasts are intended to be subtle notifications and should not require user interaction.

Thanks. Why does adding a button not work in this case?

Thanks, that makes sense. I think there is a way we can support this with just a button. The `message` prop is optional, yet the message container is still rendered....

The wrapper element itself is not a button, so it should not be clickable. It would definitely be easier, but having the container (with headers/messages) be clickable is not really...

Thanks, I can reproduce this. The issue is that components such as `ion-alert`, `ion-action-sheet`, `ion-toast`, and `ion-loading` are not reactive.

Thanks for the issue. I can reproduce this, but I still need to dig deeper to see why this is happening.

This appears to be the culprit: https://github.com/ionic-team/ionic-framework/blob/7b10fa6476c2c2896c6810c57b3160f8c8896faa/packages/react-router/src/ReactRouter/StackManager.tsx#L230-L234 When we transition to another instance of the same component `@ionic/react-router` attempts to clone the DOM nodes. This results in a duplicate `input`...

Thanks for the issue. Can you debug this a bit more? I can reproduce this behavior, but I am not able to determine if Ionic is responsible for it. I...

Ionic React does support React 18. I recommend digging into what's calling `printObjectProperties`. It looks like `printComplexValue` calls `printObjectProperties`. However, both `printComplexValue` and `printObjectProperties` call `printer`. The `printer` function can...

The issue appears to be related to a function called `proxyCustomElement` provided by Stencil, not the `createElement` change (though this function did change in 6.0.2). While there does not seem...